Skip to content

Comments

cachix: 1.7 -> 1.7.3#312433

Merged
domenkozar merged 1 commit intoNixOS:masterfrom
domenkozar:cachix-1.7.3
May 17, 2024
Merged

cachix: 1.7 -> 1.7.3#312433
domenkozar merged 1 commit intoNixOS:masterfrom
domenkozar:cachix-1.7.3

Conversation

@domenkozar
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label May 17, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 17, 2024
@domenkozar domenkozar merged commit 7b19056 into NixOS:master May 17, 2024
@drupol
Copy link
Contributor

drupol commented May 18, 2024

Do you know if this PR is the reason of the new builds failure at https://hydra.nixos.org/build/260099410 ?

@maralorn
Copy link
Member

Sounds likely. That is exactly why we prefer changes to Haskell packages to go haskell-updates.

@drupol
Copy link
Contributor

drupol commented May 18, 2024

@maralorn Is there anything I can do to fix the build failure?

@sternenseemann
Copy link
Member

Revert the PR.

@drupol
Copy link
Contributor

drupol commented May 18, 2024

Revert the PR.

OK, I'll ask it differently. Is there anything I can do to fix the issue and avoid reverting?

@maralorn
Copy link
Member

Well I think this will need a patch for hercules-ci to become cachix 1.7.3 compatlble. I don’t see an issue about that here: https://github.com/hercules-ci/hercules-ci-agent
We can ask @roberth nicely if he can provide a fix quickly, but being asked for a patch while master is already being blocked by your build failure without any prior notice is certainly not pleasant.

@drupol
Copy link
Contributor

drupol commented May 18, 2024

@roberth Let me know if you prefer to revert this instead and I'll take care of it tomorrow morning.

@domenkozar
Copy link
Member Author

Uhh, my bad. I'll add hercules-ci to the release notes for testing and make a patch tomorrow morning.

@maralorn
Copy link
Member

maralorn commented May 19, 2024

Small correction. Apparently this is not a channel blocker like I said before, sorry about the FUD.

@roberth
Copy link
Member

roberth commented May 19, 2024

Master builds with 1.7.3. I'm making a release.

@roberth
Copy link
Member

roberth commented May 19, 2024

Actually agent 0.10.2 should also build with cachix 1.7.3, but 0.10.3 and its deps have stability improvements.
Should we update those now? haskell-updates is about 4 days young, so I don't suppose we want to wait for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants