changelog-d: 0.1-git-2816ddb -> 1.0#312442
Merged
roberth merged 1 commit intoNixOS:masterfrom Jun 3, 2024
Merged
Conversation
fgaz
commented
May 17, 2024
| version = oldAttrs.version + "-git-${lib.strings.substring 0 7 oldAttrs.src.rev}"; | ||
|
|
||
| # nix-shell ./maintainers/scripts/update.nix --argstr package changelog-d | ||
| passthru.updateScript = lib.getExe (callPackage ./updateScript.nix { }); |
Member
Author
There was a problem hiding this comment.
Using a stable version breaks ./updateScript.nix. On the other hand, nix-update should now work. It won't update the list of dependencies, but those shouldn't change much.
Since the haskellPackages part of this packages will no longer be overwritten it might make sense to merge the two files. Should I do that?
Member
There was a problem hiding this comment.
I think the separation between generated code and overrides is helpful, but I can see other options, including
- you taking over the Nixpkgs maintainership of this package
- publishing releases to hackage
- makes it easy for the Cabal project to use the release (not everyone uses Nix there, I suppose)
- also solves changelog-d: fix build #302917 (comment)
ofborg
bot
added
10.rebuild-darwin: 1-10
roberth
approved these changes
Jun 3, 2024
Member
roberth
left a comment
roberth
left a comment
There was a problem hiding this comment.
updateScript isn't doing much now anyway, so let's use this.
Member
|
Thanks! |
Contributor
|
Successfully created backport PR for |
1 task
Contributor
|
Git push to origin failed for release-24.05 with exitcode 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.