Skip to content

changelog-d: fix build#302917

Merged
roberth merged 1 commit intoNixOS:masterfrom
tweag:fix/changelog-d
Apr 10, 2024
Merged

changelog-d: fix build#302917
roberth merged 1 commit intoNixOS:masterfrom
tweag:fix/changelog-d

Conversation

@infinisil
Copy link
Member

Build failed with

Error: Setup: Encountered missing or private dependencies:
base >=4.11.1.0 && <4.12 || >=4.12.0.0 && <4.13 || >=4.13.0.0 && <4.14 ||
>=4.14.0.0 && <4.15 || >=4.16.1.0 && <4.17 || >=4.17.0.0 && <4.18

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Build failed (https://hydra.nixos.org/build/254972708/nixlog/2) with

    Error: Setup: Encountered missing or private dependencies:
    base >=4.11.1.0 && <4.12 || >=4.12.0.0 && <4.13 || >=4.13.0.0 && <4.14 ||
    >=4.14.0.0 && <4.15 || >=4.16.1.0 && <4.17 || >=4.17.0.0 && <4.18
@infinisil infinisil requested a review from roberth April 9, 2024 20:18
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Apr 9, 2024
@roberth
Copy link
Member

roberth commented Apr 10, 2024

Updating it also fixes the problem.

This works:

nix-shell ./maintainers/scripts/update.nix --argstr package changelog-d

so I wonder why it wasn't auto updated.

RFC 140 doesn't affect automatic updates, right? This update script does change a file outside the by-name directory.

@infinisil
Copy link
Member Author

No idea about that. In any case I think having doJailbreak is a good thing to have by default, it prevents it breaking potentially for every deep dependency update.

Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that may be fine.

@roberth roberth merged commit e9332c9 into NixOS:master Apr 10, 2024
@ncfavier
Copy link
Member

I suggest moving this override to pkgs/development/haskell/configuration-common.nix. Otherwise the Haskell package fails to build and our infrastructure apparently can't deal with broken non-hackage packages: #307204 (comment)

@roberth roberth mentioned this pull request May 17, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants