xwayland: cherry-pick for pkg-config generation#311886
Closed
Emantor wants to merge 1 commit intoNixOS:masterfrom
Closed
xwayland: cherry-pick for pkg-config generation#311886Emantor wants to merge 1 commit intoNixOS:masterfrom
Emantor wants to merge 1 commit intoNixOS:masterfrom
Conversation
13 tasks
Xwayland generates a pkg-config file that trips up CMake since it includes a include directive where the include directory does not exist. Cherry-pick a patch from the upstream PR to fix pkg-config generation.
2219f55 to
b8a0acb
Compare
fufexan
approved these changes
May 15, 2024
K900
added a commit
to K900/nixpkgs
that referenced
this pull request
May 15, 2024
- libsystemd used for starting via sd-notify, is already in the closure via libei - libdecor used for window decorations on rootful - eglstream backend is gone Includes patch from NixOS#311886.
13 tasks
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Xwayland generates a pkg-config file that trips up CMake since it includes a include directive where the include directory does not exist. Cherry-pick a patch from the upstream PR to fix pkg-config generation.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.