bintools: fix wrapper build on FreeBSD native#311762
Closed
rhelmot wants to merge 1 commit intoNixOS:masterfrom
Closed
bintools: fix wrapper build on FreeBSD native#311762rhelmot wants to merge 1 commit intoNixOS:masterfrom
rhelmot wants to merge 1 commit intoNixOS:masterfrom
Conversation
This was referenced May 14, 2024
ofborg
bot
added
10.rebuild-darwin: 0
rhelmot
force-pushed
the
freebsd-minimal3/bintools
branch
from
0d33471 to
d61479d
Compare
Contributor
Author
|
I did some tests and determined that the outputsToInstall diff was actually unnecessary for building stdenv or the bootstrap files so I removed it. If it becomes necessary later we can add it then :) |
alyssais
reviewed
May 20, 2024
Member
There was a problem hiding this comment.
Is this one still necessary? It's not explained in the commit message.
Contributor
Author
There was a problem hiding this comment.
It is not necessary but I found it helpful in debugging different issues so I left it for future hackers. I will document it.
rhelmot
force-pushed
the
freebsd-minimal3/bintools
branch
from
d61479d to
f51b886
Compare
alyssais
approved these changes
May 20, 2024
Member
|
This could go to master! |
rhelmot
requested review from
a team,
Mic92,
dasJ,
emilylange,
kalbasit,
marcusramberg,
stigtsp,
thoughtpolice,
zakame and
zowoq
as code owners
rhelmot
force-pushed
the
freebsd-minimal3/bintools
branch
from
f51b886 to
9f76d13
Compare
rhelmot
removed request for
a team,
Mic92,
dasJ,
emilylange,
marcusramberg,
stigtsp and
zakame
Member
|
Please make sure to follow the procedure for switching branches, or GitHub will automatically subscribe a bunch of people, who then can't be unsubscribed. (Removing the request for review does not do this.) |
Member
|
Please resubmit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also port a similar fix to cc wrapper
part of #296581
This one is... complicated. The dynamic loader path should be self explanatory, but the output filtering in meta was the only thing I could figure out how to do to assuage a recursion error in stdenv/freebsd (linked). If someone else knows what exactly I'm messing with here, please feel free to issue a better fix and I'll try it out.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.