Skip to content

Comments

electrum-ltc: apply aiorpcX version bump patch#311233

Merged
RaghavSood merged 1 commit intoNixOS:masterfrom
RaghavSood:electrum-ltc/aiorpcx-patch
May 13, 2024
Merged

electrum-ltc: apply aiorpcX version bump patch#311233
RaghavSood merged 1 commit intoNixOS:masterfrom
RaghavSood:electrum-ltc/aiorpcx-patch

Conversation

@RaghavSood
Copy link
Member

@RaghavSood RaghavSood commented May 13, 2024

Description of changes

ZHF: #309482

Replicates #309576 for electrum-ltc.

The patch has to be altered slightly as electrum-ltc is too far behind electrum to use the upstream patch as-is.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@RaghavSood RaghavSood force-pushed the electrum-ltc/aiorpcx-patch branch from 78817e7 to a7b2fb0 Compare May 13, 2024 02:26
@RaghavSood RaghavSood added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label May 13, 2024
@ofborg ofborg bot requested a review from bbjubjub2494 May 13, 2024 02:52
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 13, 2024
Copy link
Member

@bbjubjub2494 bbjubjub2494 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RaghavSood RaghavSood merged commit 766d134 into NixOS:master May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants