electrum: add patch for aiorpcx compatibility#309576
Merged
prusnak merged 1 commit intoNixOS:masterfrom May 6, 2024
Merged
Conversation
electrum is quite strict about the aiorpcx version is accepts. With commit 97b53be , aiorpcx got updated to 0.23.1 which is too much for electrum. Upstream already has a patch to extend the range of aiorpcx versions it permits. We apply that patch until a the next release of electrum. Unfortunatelly, the patch -- which we take from the GitHub source repository -- does not patch every file that that is needed to be patched in the distribution tarball. Hence we have to copy the patched file over another file in the `postPatch` hook of the build process. See the comments there for more information.
ofborg
bot
added
10.rebuild-darwin: 1-10
13 tasks
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
electrumbuild broke due to theaiorpcxupdate in 97b53be via #305152 .Upstream already has a patch, however, it's not so easy to apply:
/run_electrumin the source repo/electrum/electrumpointing to../run_electrum, i.e., to the file that is patched/electrum/electrumis a simple copy of/run_electrum(probably the result of whatever process generates the tarball)/electrum/electrumis used as executable in the package outputHence, although the patch will likely fix the next electrum release, just applying it to our source does not fix the issue. To work around that, this pull request also adds a copy command to the
postFixupsection to copy the patched/run_electrumover the unpatched/electrum/electrum. This is also explained in a comment near thefetchpatchline, so whoever removes the patch when it is no longer needed is also reminded of removing the copy command below.Notifying maintainers: @joachifm @np @prusnak @chewblacka
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Result of
nixpkgs-reviewrun on x86_64-linux 12 packages built:
Add a 👍 reaction to pull requests you find important.