Skip to content

pypy27Packages.pluthon: fix eval#305843

Merged
marsam merged 1 commit intoNixOS:masterfrom
trofi:pypy27Packages.pluthon-fix-eval
Apr 22, 2024
Merged

pypy27Packages.pluthon: fix eval#305843
marsam merged 1 commit intoNixOS:masterfrom
trofi:pypy27Packages.pluthon-fix-eval

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Apr 21, 2024

Without the change the eval fails to concatenate lists as:

$ nix build --no-link -f. pypy27Packages.pluthon
error:
   … while evaluating the attribute 'drvPath'
     at lib/customisation.nix:365:7:
      364|     in commonAttrs // {
      365|       drvPath = assert condition; drv.drvPath;
         |       ^
      366|       outPath = assert condition; drv.outPath;

   … while evaluating the attribute 'drvPath'
     at lib/customisation.nix:365:7:
      364|     in commonAttrs // {
      365|       drvPath = assert condition; drv.drvPath;
         |       ^
      366|       outPath = assert condition; drv.outPath;

   … while calling the 'derivationStrict' builtin
     at <nix/derivation-internal.nix>:9:12:
        8|
        9|   strict = derivationStrict drvAttrs;
         |            ^
       10|

   (stack trace truncated; use '--show-trace' to show the full trace)

   error: expected a list but found a set: { type = "derivation"; LANG = «thunk»; __ignoreNulls = true; __structuredAttrs = «thunk»; all = «thunk»; args = «thunk»; buildInputs = «thunk»; builder = «thunk»; cmakeFlags = «thunk»; configureFlags = «thunk»; «45 attributes elided» }

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Without the change the eval fails to concatenate lists as:

    $ nix build --no-link -f. pypy27Packages.pluthon
    error:
       … while evaluating the attribute 'drvPath'
         at lib/customisation.nix:365:7:
          364|     in commonAttrs // {
          365|       drvPath = assert condition; drv.drvPath;
             |       ^
          366|       outPath = assert condition; drv.outPath;

       … while evaluating the attribute 'drvPath'
         at lib/customisation.nix:365:7:
          364|     in commonAttrs // {
          365|       drvPath = assert condition; drv.drvPath;
             |       ^
          366|       outPath = assert condition; drv.outPath;

       … while calling the 'derivationStrict' builtin
         at <nix/derivation-internal.nix>:9:12:
            8|
            9|   strict = derivationStrict drvAttrs;
             |            ^
           10|

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: expected a list but found a set: { type = "derivation"; LANG = «thunk»; __ignoreNulls = true; __structuredAttrs = «thunk»; all = «thunk»; args = «thunk»; buildInputs = «thunk»; builder = «thunk»; cmakeFlags = «thunk»; configureFlags = «thunk»; «45 attributes elided» }
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 21, 2024
@trofi trofi mentioned this pull request Apr 21, 2024
13 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 21, 2024
Copy link
Member

@t4ccer t4ccer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry!

@marsam marsam merged commit bc3d590 into NixOS:master Apr 22, 2024
@trofi trofi deleted the pypy27Packages.pluthon-fix-eval branch April 22, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants