Merged
Conversation
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
8.has: package (new)
Member
Author
|
Switching to draft, have some issues with relaxed bounds |
t4ccer
force-pushed
the
t4/opshin/init
branch
from
b09b877 to
f84a817
Compare
jnsgruk
reviewed
Mar 18, 2024
nim65s
reviewed
Mar 18, 2024
Contributor
There was a problem hiding this comment.
using rec is an anti-pattern, ref: https://discourse.nixos.org/t/avoid-rec-expresions-in-nixpkgs/8293/18 / #119942
t4ccer
force-pushed
the
t4/opshin/init
branch
2 times, most recently
from
0a54ff2 to
b0b2d5a
Compare
jnsgruk
approved these changes
Mar 19, 2024
| }; | ||
|
|
||
| propagatedBuildInputs = with python3.pkgs; [ | ||
| setuptools |
Member
There was a problem hiding this comment.
Non-blocking nit: I generally prefer lists like this to be alphabetically ordered to make updating/reasoning about them a bit easier later on 😄
nim65s
approved these changes
Mar 19, 2024
wegank
added
the
12.approvals: 2
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Added
opshinpackage, required dependencies, and fixedpycardanobuildThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.