Skip to content

paperjam: init at 1.2.1#302861

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
avdv:paperjam-init-at-1.2
Dec 7, 2024
Merged

paperjam: init at 1.2.1#302861
Aleksanaa merged 1 commit intoNixOS:masterfrom
avdv:paperjam-init-at-1.2

Conversation

@avdv
Copy link
Member

@avdv avdv commented Apr 9, 2024

Description of changes

Paperjam is a simple command line tool for manipulating PDF files (rotate pages, reorder them, put multiple pages on one for cheaper printing…). It is similar to pspdftool, but maintained (can correctly handle compressed PDFs for example).

previously: #216782
previously: https://github.com/jvns/nixpkgs/blob/22b70a48a797538c76b04261b3043165896d8f69/paperjam.nix

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@avdv avdv requested a review from AndersonTorres April 9, 2024 16:08
@avdv avdv force-pushed the paperjam-init-at-1.2 branch from 204dced to 875f58e Compare April 9, 2024 19:30
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Apr 9, 2024
@avdv avdv force-pushed the paperjam-init-at-1.2 branch from afec987 to 5b21a30 Compare June 13, 2024 18:39
@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Jun 13, 2024
@cole-h
Copy link
Member

cole-h commented Jun 25, 2024

@ofborg eval

@cole-h cole-h removed the ofborg-internal-error Ofborg encountered an error label Jun 25, 2024
@avdv avdv force-pushed the paperjam-init-at-1.2 branch 2 times, most recently from 41e5845 to 4ab6469 Compare November 18, 2024 21:25
@avdv
Copy link
Member Author

avdv commented Nov 18, 2024

Thank you for the review @FliegendeWurst ! PTAL

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build still fails for some reason:

Undefined symbols for architecture x86_64:
  "_iconv", referenced from:
      unicode_string(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>) in pdf-tools.o
  "_iconv_close", referenced from:
      unicode_string(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>) in pdf-tools.o
  "_iconv_open", referenced from:
      unicode_string(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>) in pdf-tools.o
ld: symbol(s) not found for architecture x86_64

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yes of course. Providing the dependency is not enough, one also has to link to it.

Also, I just noticed that in the meantime version 1.2.1 was released; so I updated to that.

@avdv avdv force-pushed the paperjam-init-at-1.2 branch from 4ab6469 to 02a446f Compare November 20, 2024 12:12
@avdv avdv changed the title paperjam: init at 1.2 paperjam: init at 1.2.1 Nov 20, 2024
Co-authored-by: Anderson Torres <torres.anderson.85@protonmail.com>
@avdv avdv force-pushed the paperjam-init-at-1.2 branch from 02a446f to e9bc776 Compare November 21, 2024 11:53
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 25, 2024
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Dec 1, 2024
@Aleksanaa Aleksanaa merged commit 1c09ff0 into NixOS:master Dec 7, 2024
@avdv avdv deleted the paperjam-init-at-1.2 branch January 9, 2025 14:42
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 9, 2025

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants