Merged
Conversation
204dced to
875f58e
Compare
AndersonTorres
suggested changes
Jun 9, 2024
afec987 to
5b21a30
Compare
Member
|
@ofborg eval |
FliegendeWurst
requested changes
Nov 17, 2024
41e5845 to
4ab6469
Compare
Member
Author
|
Thank you for the review @FliegendeWurst ! PTAL |
FliegendeWurst
requested changes
Nov 20, 2024
pkgs/by-name/pa/paperjam/package.nix
Outdated
Member
There was a problem hiding this comment.
The build still fails for some reason:
Undefined symbols for architecture x86_64:
"_iconv", referenced from:
unicode_string(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>) in pdf-tools.o
"_iconv_close", referenced from:
unicode_string(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>) in pdf-tools.o
"_iconv_open", referenced from:
unicode_string(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>) in pdf-tools.o
ld: symbol(s) not found for architecture x86_64
Member
Author
There was a problem hiding this comment.
Oh, yes of course. Providing the dependency is not enough, one also has to link to it.
Also, I just noticed that in the meantime version 1.2.1 was released; so I updated to that.
4ab6469 to
02a446f
Compare
Co-authored-by: Anderson Torres <torres.anderson.85@protonmail.com>
02a446f to
e9bc776
Compare
FliegendeWurst
approved these changes
Nov 24, 2024
AndersonTorres
approved these changes
Nov 30, 2024
Aleksanaa
approved these changes
Dec 7, 2024
Contributor
|
Successfully created backport PR for |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Paperjam is a simple command line tool for manipulating PDF files (rotate pages, reorder them, put multiple pages on one for cheaper printing…). It is similar to pspdftool, but maintained (can correctly handle compressed PDFs for example).
previously: #216782
previously: https://github.com/jvns/nixpkgs/blob/22b70a48a797538c76b04261b3043165896d8f69/paperjam.nix
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.