Conversation
|
Result of 1 package built:
|
ofborg
bot
added
8.has: package (new)
There was a problem hiding this comment.
| "DESTDIR=$(out)" | |
| "PREFIX=/" | |
| "PREFIX=$(out)" |
There was a problem hiding this comment.
I feel like it better represents the intent, PREFIX saying don't put it under /usr but straight under / and DESTDIR saying do a "chroot" to $out during install, but if you prefer brevity, I'll change it.
There was a problem hiding this comment.
In Nixpkgs we don't use DESTDIR.
DESTDIR exists primarily for "targz compressers" used by other distros. With it, the Makefile compiles the project as if it would be installed under PREFIX (including possible hardcoded relationships like the place of libraries and configfiles), but throws the files in a DESTDIR so that the distro packagers can post-process it (including metadata, rpm style).
This is called the poor boi's chroot. (as you said)
However nix installs its things directly in the filesystem (under /nix/store/<hash>-...). We don't targz things.
Therefore, using DESTDIR here is not only superfluous, it is fundamentally wrong.
There was a problem hiding this comment.
| license = licenses.gpl2Plus; | |
| platforms = platforms.all; | |
| maintainers = with maintainers; [ vojta001 ]; | |
| license = lib.licenses.gpl2Plus; | |
| maintainers = with lib.maintainers; [ vojta001 ]; | |
| platforms = lib.platforms.all; |
There was a problem hiding this comment.
Thanks! I'll fix it
There was a problem hiding this comment.
| meta = with lib; { | |
| meta = { |
There was a problem hiding this comment.
Looking at the Makefile, the binary would hardcode a tag name when built from a tag. Might as well use
| # by recording the exact commit, we can embed it into the binary | |
| # this can't be done automatically as fetchgit removes .git directory | |
| rev = "90173f436b39bfe39491aa356a218ac185618d1c"; | |
| rev = "v${finalAttrs.version}"; |
That will also make it easier to update the package with passthru.updateScript = gitUpdater { }; or other similar tooling.
|
Sorry for the delay, can we merge now? |
ofborg
bot
added
the
2.status: merge conflict
Apologies for the failure. |
|
Now you can restart, @vojta001 |
|
Thank you, rebased to master. |
ofborg
bot
removed
the
2.status: merge conflict
AndersonTorres
left a comment
AndersonTorres
left a comment
There was a problem hiding this comment.
I will not focus on formatting issues this time.
| ''; | ||
| license = lib.licenses.gpl2Plus; | ||
| maintainers = with lib.maintainers; [ vojta001 ]; | ||
| platforms = lib.platforms.all; |
There was a problem hiding this comment.
It is not building on Darwin. The OfBorg logs accuse the lack of iconv.
|
@vojta001 are you still interested pushing this forward? It would be nice to have 👍 FTR, some previous work: https://github.com/jvns/nixpkgs/blob/22b70a48a797538c76b04261b3043165896d8f69/paperjam.nix (blog post: https://jvns.ca/blog/2023/02/28/some-notes-on-using-nix/) |
|
Closing as dead. |
5 participants
Description of changes
Paperjam is a simple command line tool for manipulating PDF files (rotate pages, reorder them, put multiple pages on one for cheaper printing…). It is similar to
pspdftool, but maintained (can correctly handle compressed PDFs for example).Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)