Skip to content

cudaPackages.autoAddDriverRunpath: drop the redundant copy of the hook#301176

Merged
ConnorBaker merged 1 commit intoNixOS:masterfrom
SomeoneSerge:drop-cudapackages-autoAddDriverRunpath
Apr 5, 2024
Merged

cudaPackages.autoAddDriverRunpath: drop the redundant copy of the hook#301176
ConnorBaker merged 1 commit intoNixOS:masterfrom
SomeoneSerge:drop-cudapackages-autoAddDriverRunpath

Conversation

@SomeoneSerge
Copy link
Contributor

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@SomeoneSerge SomeoneSerge added the 6.topic: cuda Parallel computing platform and API label Apr 3, 2024
@SomeoneSerge SomeoneSerge force-pushed the drop-cudapackages-autoAddDriverRunpath branch from 84b9ad0 to 39f3509 Compare April 3, 2024 08:36
Copy link
Contributor Author

@SomeoneSerge SomeoneSerge Apr 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking paths: pkgs/development/cuda-modules pkgs/test/cuda pkgs/top-level/cuda-packages.nix 
pkgs/development/cuda-modules/setup-hooks/extension.nix: not formatted

😍 😍 😍

@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Apr 3, 2024
Copy link
Contributor

@ConnorBaker ConnorBaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ConnorBaker
Copy link
Contributor

All the usual nixpkgs-review stuff builds, and I was able to confirm this didn't break PyTorch on x86_64-linux using nix-cuda-test. As such, I'm merging this.

@ConnorBaker ConnorBaker merged commit f01fc7f into NixOS:master Apr 5, 2024
@Scrumplex Scrumplex mentioned this pull request May 25, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: cuda Parallel computing platform and API 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants