Skip to content

mk-python-derivation: fix config.doCheckByDefault being ignored #300338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yshui wants to merge 3 commits into from
Closed

mk-python-derivation: fix config.doCheckByDefault being ignored #300338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6cf5314
mk-python-derivation: fix config.doCheckByDefault being ignored
yshui Mar 30, 2024
8745a38
pytest-datadir: enable doCheck
yshui Apr 2, 2024
72a6519
sphinxcontrib-jquery: enable doCheck
yshui Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkgs/development/interpreters/python/mk-python-derivation.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ let

# Python packages don't have a checkPhase, only an installCheckPhase
doCheck = false;
doInstallCheck = attrs.doCheck or true;
doInstallCheck = doCheck;
nativeInstallCheckInputs = [
] ++ optionals (format' == "setuptools") [
# Longer-term we should get rid of this and require
Expand Down
2 changes: 2 additions & 0 deletions pkgs/development/python-modules/pytest-datadir/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ buildPythonPackage rec {

nativeCheckInputs = [ pytestCheckHook ];

doCheck = true;

pythonImportsCheck = [ "pytest_datadir" ];

meta = with lib; {
Expand Down
2 changes: 2 additions & 0 deletions pkgs/development/python-modules/sphinxcontrib-jquery/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ buildPythonPackage rec {
})
];

doCheck = true;

nativeBuildInputs = [
flit-core
];
Expand Down