mk-python-derivation: fix config.doCheckByDefault being ignored

[yshui]

Description of changes

make buildPythonPackage respect config.doCheckByDefault.

Don't know if you know this: { ... } @ attrs syntax won't include default arguments in attrs (!!). So despite the , doCheck ? config.doCheckByDefault or false in the parameter list, attrs.doCheck will not exist if doCheck is not explicitly passed. And because doCheck is only accessed through attrs, the default argument is meaningless there.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[yshui]

Perhaps the intention is indeed to enable check by default unless disabled, in that case the default argument config.doCheckByDefault in the parameter list is confusing and should be removed.

[kira-bruneau]

Perhaps the intention is indeed to enable check by default unless disabled, in that case the default argument config.doCheckByDefault in the parameter list is confusing and should be removed.

Oh yep, it looks like that was addressed in #308377.