Skip to content

rocmPackages: fix deprecation notices #300220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ulrikstrid merged 2 commits into from
Apr 1, 2024
Merged

rocmPackages: fix deprecation notices #300220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfca76c
rocmPackages: fix miopengemm deprecation notices
mschwaig Mar 24, 2024
710e06c
rocmPackages: add deprecation notice for 'mivisionx-opencl'
mschwaig Mar 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions pkgs/development/rocm-modules/6/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,9 +236,9 @@ in rec {
# hipTensor - Only supports GFX9

miopengemm= throw ''
'miopen-opencl' has been deprecated.
'miopengemm' has been deprecated.
It is still available for some time as part of rocmPackages_5.
''; # Added 2024-3-3;
''; # Added 2024-3-3

composable_kernel = callPackage ./composable_kernel {
inherit rocmUpdateScript rocm-cmake clr;
Expand All @@ -264,7 +264,7 @@ in rec {
miopen-opencl= throw ''
'miopen-opencl' has been deprecated.
It is still available for some time as part of rocmPackages_5.
''; # Added 2024-3-3;
''; # Added 2024-3-3

migraphx = callPackage ./migraphx {
inherit rocmUpdateScript rocm-cmake rocblas composable_kernel miopen clr half rocm-device-libs;
Expand Down Expand Up @@ -322,12 +322,11 @@ in rec {
useCPU = false;
};

mivisionx-opencl = mivisionx.override {
rpp = rpp-opencl;
miopen = miopen-opencl;
useOpenCL = true;
useCPU = false;
};
mivisionx-opencl = throw ''
'mivisionx-opencl' has been deprecated.
Other versions of mivisionx are still available.
It is also still available for some time as part of rocmPackages_5.
''; # Added 2024-3-24

mivisionx-cpu = mivisionx.override {
rpp = rpp-cpu;
Expand Down
2 changes: 1 addition & 1 deletion pkgs/top-level/aliases.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,7 +762,7 @@ mapAliases ({
migraphx = throw "'migraphx' has been replaced with 'rocmPackages.migraphx'"; # Added 2023-10-08
minishift = throw "'minishift' has been removed as it was discontinued upstream. Use 'crc' to setup a microshift cluster instead"; # Added 2023-12-30
miopen = throw "'miopen' has been replaced with 'rocmPackages.miopen'"; # Added 2023-10-08
miopengemm = throw "'miopengemm' has been replaced with 'rocmPackages.miopengemm'"; # Added 2023-10-08
miopengemm = throw "'miopengemm' has been replaced with 'rocmPackages_5.miopengemm'"; # Added 2023-10-08
miopen-hip = throw "'miopen-hip' has been replaced with 'rocmPackages.miopen-hip'"; # Added 2023-10-08
miopen-opencl = throw "'miopen-opencl' has been replaced with 'rocmPackages.miopen-opencl'"; # Added 2023-10-08
mime-types = mailcap; # Added 2022-01-21
Expand Down