Skip to content

rocmPackages: fix deprecation notices#300220

Merged
ulrikstrid merged 2 commits intoNixOS:masterfrom
mschwaig:fix-rocm-deprecation-notices
Apr 1, 2024
Merged

rocmPackages: fix deprecation notices#300220
ulrikstrid merged 2 commits intoNixOS:masterfrom
mschwaig:fix-rocm-deprecation-notices

Conversation

@mschwaig
Copy link
Member

@mschwaig mschwaig commented Mar 30, 2024

Description of changes

This cleans up some of the deprecation notices that I added with ROCm 6.0 (#287846), which were or became inaccurate,
and deprecates mivisionx-opencl since miopen-opencl was deprecated in ROCm 6.0.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@mschwaig mschwaig requested a review from ulrikstrid March 30, 2024 12:35
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 30, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 30, 2024
@ulrikstrid ulrikstrid merged commit dae0b15 into NixOS:master Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants