haskell.compiler.{ghc98*,ghcHEAD}: bootstrap using source built 9.6#297804
Merged
sternenseemann merged 1 commit intoNixOS:masterfrom Mar 21, 2024
Merged
Conversation
Unfortunately, we are running into trouble linking dependencies of hadrian against the libraries of the clock package with 9.6.3 and 9.6.4 _bindists_. My current suspiscion is that this is caused by some kind of discrepancy between the toolchain used by GHC upstream and us that persists from the configure step used when building the bindist. The problem seems to be somewhat localized to hsc2hs (hence clock is an issue), with GHC 9.6.4 bindists even passing a flag to ld that is not supported by our version of cctools. The problem is not fully diagnosed, so take the speculation above with a grain of salt. As a workaround, we can use the source built GHC 9.6 which is, of course, configured with our toolchain in the environment.
github-actions
bot
added
the
6.topic: haskell
13 tasks
ofborg
bot
added
10.rebuild-darwin: 1-10
Contributor
|
There are two separate issues here. GHC 9.6.3 has an aarch64 code layout issue. It's hard to say exactly when it will or won't happen, so I'm not surprised that we happen to hit this when bootstrapping with the bindist but not with the Nix-built 9.6.3. Totally separately 9.6.4's bindist has a bugged hsc2hs (related issue) on darwin. @sternenseemann if we're going to bootstrap with a Nix-built GHC anyway, I think we'd be safer using 9.6.4 instead of 9.6.3. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, we are running into trouble linking dependencies of hadrian against the libraries of the clock package with 9.6.3 and 9.6.4 bindists. My current suspiscion is that this is caused by some kind of discrepancy between the toolchain used by GHC upstream and us that persists from the configure step used when building the bindist. The problem seems to be somewhat localized to hsc2hs (hence clock is an issue), with GHC 9.6.4 bindists even passing a flag to ld that is not supported by our version of cctools.
The problem is not fully diagnosed, so take the speculation above with a grain of salt.
As a workaround, we can use the source built GHC 9.6 which is, of course, configured with our toolchain in the environment.
Fast track into master.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.