Skip to content

treewide: remove gst-plugins-good missing libsoup_3 workaround #294284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Mar 8, 2024
Merged

treewide: remove gst-plugins-good missing libsoup_3 workaround #294284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions pkgs/applications/audio/radiotray-ng/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
# GStreamer
, glib-networking
, gst_all_1
, libsoup_3
# User-agent info
, lsb-release
# rt2rtng
Expand Down Expand Up @@ -100,8 +99,6 @@ stdenv.mkDerivation rec {
preFixup = ''
gappsWrapperArgs+=(--suffix PATH : ${lib.makeBinPath [ dbus ]})
wrapProgram $out/bin/rt2rtng --prefix PYTHONPATH : $PYTHONPATH
# for GStreamer
gappsWrapperArgs+=(--prefix LD_LIBRARY_PATH : "${lib.getLib libsoup_3}/lib")
'';

meta = with lib; {
Expand Down
7 changes: 0 additions & 7 deletions pkgs/by-name/gl/glide-media-player/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
, gst_all_1
, glib-networking
, darwin
, libsoup_3
}:

stdenv.mkDerivation rec {
Expand Down Expand Up @@ -69,12 +68,6 @@ stdenv.mkDerivation rec {
darwin.apple_sdk_11_0.frameworks.IOKit
];

# FIXME: gst-plugins-good missing libsoup breaks streaming
# (https://github.com/nixos/nixpkgs/issues/271960)
preFixup = ''
gappsWrapperArgs+=(--prefix LD_LIBRARY_PATH : "${lib.makeLibraryPath [ libsoup_3 ]}")
'';

meta = with lib; {
description = "Linux/macOS media player based on GStreamer and GTK";
homepage = "https://philn.github.io/glide";
Expand Down
4 changes: 0 additions & 4 deletions pkgs/by-name/mo/monophony/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
, gobject-introspection
, yt-dlp
, libadwaita
, libsoup_3
, glib-networking
, nix-update-script
}:
Expand Down Expand Up @@ -38,7 +37,6 @@ python3Packages.buildPythonApplication rec {
buildInputs = [
libadwaita
# needed for gstreamer https
libsoup_3
glib-networking
] ++ (with gst_all_1; [
gst-plugins-base
Expand All @@ -53,8 +51,6 @@ python3Packages.buildPythonApplication rec {
gappsWrapperArgs+=(
--prefix PYTHONPATH : "$program_PYTHONPATH"
--prefix PATH : "${lib.makeBinPath [yt-dlp]}"
# needed for gstreamer https
--prefix LD_LIBRARY_PATH : "${lib.getLib libsoup_3}/lib"
)
'';

Expand Down
7 changes: 0 additions & 7 deletions pkgs/by-name/ne/netease-cloud-music-gtk/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
, libadwaita
, glib-networking
, gst_all_1
, libsoup_3
}:

stdenv.mkDerivation rec {
Expand Down Expand Up @@ -71,12 +70,6 @@ stdenv.mkDerivation rec {
gst-plugins-ugly
]);

# FIXME: gst-plugins-good missing libsoup breaks streaming
# (https://github.com/nixos/nixpkgs/issues/271960)
preFixup = ''
gappsWrapperArgs+=(--prefix LD_LIBRARY_PATH : "${lib.makeLibraryPath [ libsoup_3 ]}")
'';

meta = with lib; {
description = "A Rust + GTK based netease cloud music player";
homepage = "https://github.com/gmg137/netease-cloud-music-gtk";
Expand Down