treewide: remove gst-plugins-good missing libsoup_3 workaround#294284
Merged
1 commit merged intoNixOS:masterfrom Mar 8, 2024
Merged
treewide: remove gst-plugins-good missing libsoup_3 workaround#2942841 commit merged intoNixOS:masterfrom
1 commit merged intoNixOS:masterfrom
Conversation
ghost
approved these changes
Mar 8, 2024
ghost
left a comment
There was a problem hiding this comment.
thanks! ran radiotray-ng and monophony. works as expected
Member
Author
|
Then it should be okay. glide-music-player and netease-cloud-music-gtk also work as expected. |
As the issue NixOS#271960 is fixed by NixOS#276408
237c7f9 to
2a1cd0b
Compare
|
@ofborg build monophony monophony.passthru.tests radiotray-ng radiotray-ng.passthru.tests glide-media-player glide-media-player.passthru.tests netease-cloud-music-gtk netease-cloud-music-gtk.passthru.tests |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
As the issue (gst-plugins-good cannot find libsoup_3 with dlopen) is fixed by #276408 (The pr already hits nixos-unstable-small).
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.