Skip to content

treewide: remove gst-plugins-good missing libsoup_3 workaround#294284

Merged
1 commit merged intoNixOS:masterfrom
Aleksanaa:gstreamer-libsoup3-fix
Mar 8, 2024
Merged

treewide: remove gst-plugins-good missing libsoup_3 workaround#294284
1 commit merged intoNixOS:masterfrom
Aleksanaa:gstreamer-libsoup3-fix

Conversation

@Aleksanaa
Copy link
Member

@Aleksanaa Aleksanaa commented Mar 8, 2024

Description of changes

As the issue (gst-plugins-good cannot find libsoup_3 with dlopen) is fixed by #276408 (The pr already hits nixos-unstable-small).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Aleksanaa Aleksanaa requested review from a user, Henry-Hiles and dtzWill March 8, 2024 14:18
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! ran radiotray-ng and monophony. works as expected

@Aleksanaa
Copy link
Member Author

Then it should be okay. glide-music-player and netease-cloud-music-gtk also work as expected.

@Aleksanaa Aleksanaa force-pushed the gstreamer-libsoup3-fix branch from 237c7f9 to 2a1cd0b Compare March 8, 2024 14:54
@ofborg ofborg bot requested a review from Diffumist March 8, 2024 15:08
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 8, 2024
@ghost
Copy link

ghost commented Mar 8, 2024

@ofborg build monophony monophony.passthru.tests radiotray-ng radiotray-ng.passthru.tests glide-media-player glide-media-player.passthru.tests netease-cloud-music-gtk netease-cloud-music-gtk.passthru.tests

@ghost ghost merged commit dfd80c8 into NixOS:master Mar 8, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant