Skip to content

python3Packages.email-validator: 2.1.0 -> 2.1.1#293715

Merged
doronbehar merged 1 commit intoNixOS:stagingfrom
endgame:python-email-validator-bump-and-archive-tarball
Mar 7, 2024
Merged

python3Packages.email-validator: 2.1.0 -> 2.1.1#293715
doronbehar merged 1 commit intoNixOS:stagingfrom
endgame:python-email-validator-bump-and-archive-tarball

Conversation

@endgame
Copy link
Contributor

@endgame endgame commented Mar 6, 2024

Description of changes

https://github.com/JoshData/python-email-validator/releases/tag/v2.1.1

Upstream reissued their 2.1.0 tarball, breaking non-cache fetches. May as well move to the new release.

Closes #291925

CC Maintainer: @langston-barrett

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Mar 6, 2024
@endgame
Copy link
Contributor Author

endgame commented Mar 6, 2024

Check failure is:

error: access to URI 'http://web.archive.org/web/20240306093519/https://codeload.github.com/JoshData/python-email-validator/tar.gz/refs/tags/v2.1.1' is forbidden in restricted mode

I was advised to use archive.org because upstream likes to push over the top of its tarballs, but clearly I haven't done it in the right way — any tips?

@endgame endgame force-pushed the python-email-validator-bump-and-archive-tarball branch from 26b5970 to c4eb1d6 Compare March 6, 2024 20:10
@ofborg ofborg bot requested a review from langston-barrett March 6, 2024 20:36
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Mar 6, 2024
@doronbehar
Copy link
Contributor

Looks good to me, let's cook this in staging..

@doronbehar doronbehar merged commit e713727 into NixOS:staging Mar 7, 2024
@endgame endgame deleted the python-email-validator-bump-and-archive-tarball branch March 7, 2024 21:42
@mweinelt
Copy link
Member

mweinelt commented Mar 9, 2024

I could never download the src tarball from archive.org. It would always run into an HTTP 404 for me. Hence, in #294305 I migrated the package to the pypi sdist source, which should be the obvious choice in that situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants