python3Packages.email-validator: 2.1.0 -> 2.1.1#293715
Merged
doronbehar merged 1 commit intoNixOS:stagingfrom Mar 7, 2024
Merged
python3Packages.email-validator: 2.1.0 -> 2.1.1#293715doronbehar merged 1 commit intoNixOS:stagingfrom
doronbehar merged 1 commit intoNixOS:stagingfrom
Conversation
13 tasks
Contributor
Author
|
Check failure is:
I was advised to use archive.org because upstream likes to push over the top of its tarballs, but clearly I haven't done it in the right way — any tips? |
doronbehar
reviewed
Mar 6, 2024
26b5970 to
c4eb1d6
Compare
Contributor
|
Looks good to me, let's cook this in staging.. |
Member
|
I could never download the src tarball from archive.org. It would always run into an HTTP 404 for me. Hence, in #294305 I migrated the package to the pypi sdist source, which should be the obvious choice in that situation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
https://github.com/JoshData/python-email-validator/releases/tag/v2.1.1
Upstream reissued their 2.1.0 tarball, breaking non-cache fetches. May as well move to the new release.
Closes #291925
CC Maintainer: @langston-barrett
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.