python3Packages.email-validator: 2.1.0 -> 2.1.1#291925
python3Packages.email-validator: 2.1.0 -> 2.1.1#291925endgame wants to merge 1 commit intoNixOS:masterfrom
Conversation
https://github.com/JoshData/python-email-validator/releases/tag/v2.1.1 Upstream reissued their 2.1.0 tarball, breaking non-cache fetches. May as well move to the new release.
If upstream is known to do these things (I seems that also happened to 2.0.0), wouldn't it be better to reference the release by commit instead of by tag? (This is not a rhetoric question. I'm somewhat new to nix and really asking.) For reference:
|
|
I don't know either, and I'm not sure what nixpkgs' best practice is. I was just testing some "what can I build without substituters?" and decided to drive-by a fix. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
Note there are a lot of rebuilds, this PR should target |
Commonly we use archive.org for hash-unstable urls. If the new tarballs include security fixes, then they could be added in follow-up PRs |
|
Closing in favour of #293715 so I don't ping a zillion people by fiddling with branches. |
Description of changes
https://github.com/JoshData/python-email-validator/releases/tag/v2.1.1
Upstream reissued their 2.1.0 tarball, breaking non-cache fetches. May as well move to the new release.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.