Skip to content

boehmgc: migrate to by-name #292127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wegank merged 2 commits into from
Mar 8, 2024
Merged

boehmgc: migrate to by-name #292127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82fe693
boehmgc: migrate to by-name
AndersonTorres Feb 28, 2024
b11d788
boehmgc: get rid of nested with
AndersonTorres Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions ...evelopment/libraries/boehm-gc/default.nix → pkgs/by-name/bo/boehmgc/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ stdenv.mkDerivation (finalAttrs: {

passthru.tests = nixVersions;

meta = with lib; {
meta = {
homepage = "https://hboehm.info/gc/";
description = "The Boehm-Demers-Weiser conservative garbage collector for C and C++";
longDescription = ''
Expand All @@ -76,10 +76,9 @@ stdenv.mkDerivation (finalAttrs: {
Alternatively, the garbage collector may be used as a leak detector for
C or C++ programs, though that is not its primary goal.
'';
# non-copyleft, X11-style license
changelog = "https://github.com/ivmai/bdwgc/blob/v${finalAttrs.version}/ChangeLog";
license = "https://hboehm.info/gc/license.txt";
maintainers = with maintainers; [ AndersonTorres ];
platforms = platforms.all;
license = "https://hboehm.info/gc/license.txt"; # non-copyleft, X11-style license
Copy link
Member Author

@AndersonTorres AndersonTorres Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can I create a license for this guy?

Copy link
Contributor

@Mindavi Mindavi Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me, or do you think it should be different?

Copy link
Member Author

@AndersonTorres AndersonTorres Mar 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My memory is bad today to catch links.
I remember an issue about those license links. Since they do not have a full structure like the ones in licenses file, they were being treated as "free by default".

maintainers = with lib.maintainers; [ AndersonTorres ];
platforms = lib.platforms.all;
};
})
3 changes: 0 additions & 3 deletions pkgs/top-level/all-packages.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20511,9 +20511,6 @@ with pkgs;
then pkgs."androidndkPkgs_${stdenv.hostPlatform.ndkVer}".libraries
else callPackage ../os-specific/linux/bionic-prebuilt { };


boehmgc = callPackage ../development/libraries/boehm-gc { };

boolstuff = callPackage ../development/libraries/boolstuff { };

inherit (callPackage ../development/libraries/boost { inherit (buildPackages) boost-build; })
Expand Down