boehmgc: migrate to by-name#292127
Merged
wegank merged 2 commits intoNixOS:masterfrom Mar 8, 2024
atorres1985-contrib:boehmgc
Merged
boehmgc: migrate to by-name#292127wegank merged 2 commits intoNixOS:masterfrom atorres1985-contrib:boehmgc
wegank merged 2 commits intoNixOS:masterfrom
atorres1985-contrib:boehmgc
Conversation
Member
Author
|
Related: #288435 |
ofborg
bot
added
10.rebuild-darwin: 0
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3573 |
Member
Author
|
For the future reviewers: This PR generated zero rebuilds. Should I throw it over Staging? |
AndersonTorres
commented
Mar 4, 2024
| license = "https://hboehm.info/gc/license.txt"; | ||
| maintainers = with maintainers; [ AndersonTorres ]; | ||
| platforms = platforms.all; | ||
| license = "https://hboehm.info/gc/license.txt"; # non-copyleft, X11-style license |
Member
Author
There was a problem hiding this comment.
How can I create a license for this guy?
Contributor
There was a problem hiding this comment.
This seems fine to me, or do you think it should be different?
Member
Author
There was a problem hiding this comment.
My memory is bad today to catch links.
I remember an issue about those license links. Since they do not have a full structure like the ones in licenses file, they were being treated as "free by default".
Mindavi
approved these changes
Mar 4, 2024
Contributor
|
No need to go through staging for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
And small refactors.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.