Skip to content

grpc: 1.60.0 -> 1.61.0 #285921

Merged
vcunat merged 7 commits intoNixOS:staging-nextfrom
marsam:update-grpc
Feb 9, 2024
Merged

grpc: 1.60.0 -> 1.61.0 #285921
vcunat merged 7 commits intoNixOS:staging-nextfrom
marsam:update-grpc

Conversation

@marsam
Copy link
Contributor

@marsam marsam commented Feb 2, 2024

Diff: grpc/grpc@v1.60.0...v1.61.0

Changelog: https://github.com/grpc/grpc/releases/tag/v1.61.0

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Feb 2, 2024
@ofborg ofborg bot requested review from LnL7, fabaff and happysalada February 3, 2024 01:06
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Feb 3, 2024
@marsam marsam changed the base branch from master to staging-next February 3, 2024 13:15
@marsam marsam marked this pull request as ready for review February 3, 2024 13:15
@happysalada
Copy link
Contributor

happysalada commented Feb 3, 2024

I'm running a nixpkgs review that is stuck at the moment for some reason.
It seems though as grpc-1.61 is failing in the build phase on x86_64-linux, did you manage to build it on your local ?
(I ran the review when this was based off of master, so that might be because of some missing fixes).
(on the face of it, no problem with this change. Note that some of the grpcio python libs update have already hit master).

@marsam
Copy link
Contributor Author

marsam commented Feb 4, 2024

It seems though as grpc-1.61 is failing in the build phase on x86_64-linux, did you manage to build it on your local ?

That's it odd. I build it on x86_64-linux, and it seems that Ofborg can also build it.

@happysalada
Copy link
Contributor

I tried running a nixpkgs-review but it got stuck in the middle.
grpc does build on linux after the branch was based on staging.
There are failures, but It's normal, it's probably some staging changes.
This looks good to merge.

@vcunat
Copy link
Member

vcunat commented Feb 6, 2024

Let's try again, after Hydra got binaries:
@ofborg build grpc

@vcunat
Copy link
Member

vcunat commented Feb 6, 2024

grpc build on *-darwin was broken by PR #284710 and this update doesn't seem to help that.

@vcunat vcunat merged commit b38903d into NixOS:staging-next Feb 9, 2024
@vcunat
Copy link
Member

vcunat commented Feb 9, 2024

I guess let's roll this forward, as you think it's OK. But we'll probably still want to address the darwin regression from abseil-cpp update.

@marsam
Copy link
Contributor Author

marsam commented Feb 9, 2024

Fix for grpc build on darwin #287548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants