Skip to content

abseil-cpp: 202301 -> 202401 #284710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
h7x4 merged 1 commit into from
Feb 2, 2024
Merged

abseil-cpp: 202301 -> 202401 #284710

h7x4 merged 1 commit into from
Feb 2, 2024

Conversation

@GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Jan 29, 2024 •
edited
Loading

Description of changes

Change the default version of abseil-cpp to the latest one (202401).

Changelog: https://github.com/abseil/abseil-cpp/releases/tag/20240116.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jan 29, 2024
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 29, 2024

rebased to try to fix the github actions

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 29, 2024

Successfull build nix build .#telegram-desktop .#libreoffice .#grpc .#protobuf .#bloaty

@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Jan 30, 2024

Anymore builds to test before merging ?
I can run some on my hardware if needed.

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 30, 2024
@GaetanLepage GaetanLepage requested a review from h7x4 February 2, 2024 09:05
@h7x4 h7x4 merged commit 4f17401 into NixOS:staging Feb 2, 2024
@GaetanLepage GaetanLepage deleted the abseil branch February 2, 2024 16:19
@vcunat
Copy link
Member

vcunat commented Feb 3, 2024 •
edited
Loading

So, I believe this PR caused this regression on *-darwin:
https://hydra.nixos.org/build/248411515/nixlog/1/tail

Currently in PR #285983

@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Feb 3, 2024

So, I believe this PR caused this regression: https://hydra.nixos.org/build/248411515/nixlog/1/tail

Currently in PR #285983

Would bumping grpc help ?

@vcunat
Copy link
Member

vcunat commented Feb 3, 2024

(I don't know.)

@vcunat
Copy link
Member

vcunat commented Feb 6, 2024

Apparently updating does not help:
https://github.com/NixOS/nixpkgs/pull/285921/checks?check_run_id=21288775543

@vcunat vcunat mentioned this pull request Feb 6, 2024
Merged
13 tasks
@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Feb 6, 2024

Apparently updating does not help:

Ok, thank you for trying.
I wonder why this break specifically on darwin and not on linux...
Hint: grpc/grpc#34663

@vcunat
Copy link
Member

vcunat commented Feb 7, 2024

GitHub says that the linked change was included in the current grpc version already (1.60.0).

@vcunat
Copy link
Member

vcunat commented Feb 9, 2024

Resolved by PR #287548

@mweinelt mweinelt mentioned this pull request Feb 14, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@vcunat vcunat Awaiting requested review from vcunat

@andersk andersk Awaiting requested review from andersk

@jonringer jonringer Awaiting requested review from jonringer

@anthonyroussel anthonyroussel Awaiting requested review from anthonyroussel

@WilliButz WilliButz Awaiting requested review from WilliButz

@cpages cpages Awaiting requested review from cpages

@gbtb gbtb Awaiting requested review from gbtb

@h7x4 h7x4 Awaiting requested review from h7x4

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@GaetanLepage @SuperSandro2000 @vcunat @delroth @h7x4