Skip to content

Conversation

@vcunat
Copy link
Member

@vcunat vcunat commented Jan 26, 2024

Connor Baker and others added 30 commits December 22, 2023 00:10
This commit adds a test for the newly added support for
__structuredAttrs in autoPatchelf(hook). It copied a reasonably
small-closure binary derivation that makes use of autoPatchelf, stripped
it down for the purpose of the test, and check that autoPatchelf
correctly set the interpreter and runpath whether __structuredAttrs is
set to true or not.

(cherry picked from commit 00d0418)
[Backport staging-23.11] auto-patchelf: add support for __structuredAttrs
(cherry picked from commit 9e8a41f)
[Backport staging-23.11] readline: 8.2p1 -> 8.2p7
Companion to #280145 reverting it on `staging-23.11`. On staging
`staging-23.11` we are on `readline-8.2p7`, not `readline-8.2p1`, and we
can use the never version of the patch.

This reverts commit cd76713.
…gap-staging

[staging-23.11] readline: Get rid of temporary patch downgrade #280145
(cherry picked from commit 1824597)
[Backport staging-23.11] pipewire: 1.0.0 -> 1.0.1
This change applies the upstream PR
llvm/llvm-project#77218 so the same link flags
on darwin are used as when LIBCXX_CXX_ABI=libcxxabi. Specifically, this
adds
"-Wl,-force_symbols_not_weak_list,${CMAKE_CURRENT_SOURCE_DIR}/../lib/notweak.exp"
which prevents libcxx from segfaulting on darwin

(cherry picked from commit 7b62547)
[Backport staging-23.11] gtk3: 3.24.38 → 3.24.39
[Backport staging-23.11] llvmPackages_{15,16,17,git}.libcxx: use LIBCXX_CXX_ABI=libcxxabi link flags on darwin
[Backport staging-23.11] redis: 7.2.3 -> 7.2.4
@vcunat vcunat added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Jan 26, 2024
@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: emacs Text editor labels Jan 26, 2024
@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jan 26, 2024
@veprbl
Copy link
Member

veprbl commented Jan 27, 2024

This fixes an important regression on darwin (#278945), would be nice to get this in asap.

@vcunat
Copy link
Member Author

vcunat commented Jan 28, 2024

Hydra's been busy about this. I expect the rebuilding will take a couple more days, and then we'll see if we avoided any significant regressions.

@veprbl
Copy link
Member

veprbl commented Jan 31, 2024

Looks good?

@vcunat
Copy link
Member Author

vcunat commented Feb 1, 2024

13k builds not finished yet, but so far I've seen no blocker.

@bjornfor
Copy link
Contributor

bjornfor commented Feb 1, 2024

13k builds not finished yet, but so far I've seen no blocker.

Yesterday it was only 1500 builds. Do we graph the remaining builds over time somewhere? 😄

@vcunat
Copy link
Member Author

vcunat commented Feb 1, 2024

I'm not aware of such graphs. At some point it might've been around that low, but there were many thousands of transitive failures due to some transient issues.

EDIT: I mean, remaining builds aren't such an important metric to me, more like getting about the usual ~213k successes and checking if regressions contain anything that looks important.

@vcunat vcunat merged commit 25e3d4c into release-23.11 Feb 1, 2024
@vcunat
Copy link
Member Author

vcunat commented Feb 1, 2024

I think it should be OK now.

@bjornfor
Copy link
Contributor

bjornfor commented Feb 2, 2024

Yay! Now just waiting for it to hit the channel: https://nixpk.gs/pr-tracker.html?pr=284049

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: emacs Text editor 6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.