[staging-23.11] readline: Get rid of temporary patch downgrade #280145 #280149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
requested review from
RaitoBezarius,
emilylange,
jonringer and
mweinelt
as code owners
github-actions
bot
added
6.topic: nixos
13 tasks
d6162d7 did the "proper" work of fixing the MinGW readline build, but won't work without 9cc3559 which adds upstream-provided patches but is only `staging-23.11`. The older version of this patch however doesn't rely on p2-p7 so it will work for now. `staging-23.11` will revert this because it does have those patches. The urgency is because this blocks Nix Windows development.
…g-23.11 Companion to NixOS#280145 reverting it on `staging-23.11`. On staging `staging-23.11` we are on `readline-8.2p7`, not `readline-8.2p1`, and we can use the never version of the patch. This reverts commit cd76713.
Ericson2314
force-pushed
the
readline-windows-stopgap-staging
branch
from
4aa6a72 to
0d807a5
Compare
Ericson2314
changed the title
Ericson2314
changed the title
Member
|
The diff is empty. |
ofborg
bot
added
10.rebuild-darwin: 0
Member
Author
|
That is intentional, the first commit from #280145 is now on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Companion to #280145 reverting it on
staging-23.11. On stagingstaging-23.11we are onreadline-8.2p7, notreadline-8.2p1, and we can use the never version of the patch.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.