Skip to content

[Backport release-23.11] aws-azure-login: Link Puppeteer to Chromium#281196

Merged
imincik merged 2 commits intorelease-23.11from
backport-272592-to-release-23.11
Jan 16, 2024
Merged

[Backport release-23.11] aws-azure-login: Link Puppeteer to Chromium#281196
imincik merged 2 commits intorelease-23.11from
backport-272592-to-release-23.11

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jan 15, 2024

Bot-based backport to release-23.11, triggered by a label in #272592.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

l0b0 added 2 commits January 15, 2024 18:13
@l0b0 @github-actions
aws-azure-login: Take maintainership
1e56afd 
The original maintainer no longer uses this software
<#272544 (comment)>.

(cherry picked from commit 7a2dce1)
@l0b0 @github-actions
aws-azure-login: Link Puppeteer to Chromium
ca1098d 
Closes #272544.

The test verifies that the command fails for the *right* reason, rather
than the original issue:

> Error: Could not find expected browser (chrome) locally. Run `npm
> install` to download the correct Chromium revision (982053).

(cherry picked from commit 44896b1)
@github-actions github-actions bot mentioned this pull request Jan 15, 2024
Merged
13 tasks
@l0b0 l0b0 requested review from dotlambda and imincik January 15, 2024 19:40
@imincik
Copy link
Contributor

imincik commented Jan 15, 2024

@ofborg build aws-azure-login aws-azure-login.tests

@ofborg ofborg bot added the 8.has: clean-up This PR removes packages or removes other cruft label Jan 16, 2024
@ofborg ofborg bot requested a review from l0b0 January 16, 2024 00:48
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 16, 2024
@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jan 16, 2024
@imincik imincik merged commit 106907b into release-23.11 Jan 16, 2024
@imincik imincik deleted the backport-272592-to-release-23.11 branch January 16, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imincik imincik Awaiting requested review from imincik

@dotlambda dotlambda Awaiting requested review from dotlambda

1 more reviewer

@l0b0 l0b0 l0b0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@imincik @l0b0 @delroth