aws-azure-login: Link Puppeteer to Chromium

[l0b0]

Description of changes

Closes #272544, avoiding the following runtime error:

Error: Could not find expected browser (chrome) locally. Run npm install to download the correct Chromium revision (982053).

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[imincik]

Thanks for fixing the package. Fix looks good to me but I'll made some comments and requested few changes. After that, I am good to merge this PR.

Here is the example of using finalAttrs function plus some other changes I requested:

diff --git a/pkgs/by-name/aw/aws-azure-login/package.nix b/pkgs/by-name/aw/aws-azure-login/package.nix
index e6eaa7fde372..164be566ee2f 100644
--- a/pkgs/by-name/aw/aws-azure-login/package.nix
+++ b/pkgs/by-name/aw/aws-azure-login/package.nix
@@ -1,28 +1,28 @@
 { lib
+, runCommand
 , stdenv
-, callPackage
+
 , chromium
 , fetchFromGitHub
 , fetchYarnDeps
 , makeWrapper
 , nodejs
-, pkgs
 , prefetch-yarn-deps
 , yarn
 }:
-stdenv.mkDerivation rec {
+stdenv.mkDerivation (finalAttrs: {
   pname = "aws-azure-login";
   version = "3.6.1";

   src = fetchFromGitHub {
     owner = "aws-azure-login";
     repo = "aws-azure-login";
-    rev = "v${version}";
+    rev = "v${finalAttrs.version}";
     hash = "sha256-PvPnqaKD98h3dCjEOwF+Uc86xCJzn2b9XNHHn13h/2Y=";
   };

   offlineCache = fetchYarnDeps {
-    yarnLock = "${src}/yarn.lock";
+    yarnLock = "${finalAttrs.src}/yarn.lock";
     hash = "sha256-SXQPRzF6b1FJl5HkyXNm3kGoNSDXux+0RYXBX93mOts=";
   };

@@ -69,7 +69,7 @@ stdenv.mkDerivation rec {
   '';

   passthru.tests.aws-azure-login =
-    pkgs.runCommand "${pname}-tests"
+    runCommand "${finalAttrs.pname}-tests"
       {
         HOME = "/tmp/home";
       } ''
@@ -84,7 +84,7 @@ stdenv.mkDerivation rec {
       azure_default_remember_me=false
       EOF

-      ! ${lib.getExe pkgs.aws-azure-login} --profile=my-profile 2> stderr
+      ! ${lib.getExe finalAttrs.finalPackage} --profile=my-profile 2> stderr
       [[ "$(cat stderr)" == 'Unable to recognize page state! A screenshot has been dumped to aws-azure-login-unrecognized-state.png. If this problem persists, try running with --mode=gui or --mode=debug' ]]

       touch $out
@@ -98,4 +98,4 @@ stdenv.mkDerivation rec {
     maintainers = with lib.maintainers; [ l0b0 ];
     platforms = lib.platforms.all;
   };
-}
+})

[imincik]

Result of nixpkgs-review pr 272592 run on x86_64-linux 1

1 package built:

• aws-azure-login

[imincik]

Looks good to me now. Will merge once ofborg-eval is completed.

[github-actions]

Successfully created backport PR for release-23.11:

• [Backport release-23.11] aws-azure-login: Link Puppeteer to Chromium #281196