folks: disable checks#280909
Merged
nh2 merged 1 commit intoNixOS:masterfrom Jan 14, 2024
amaxine:folks-disable-checks
Merged
Conversation
Contributor
Author
|
I'd rather fix it but since the timeouts are extremely random I've not had the time to put together something for reproing this yet. |
Member
|
LGTM, can you also put a comment linking to #279843 (comment)? |
Contributor
Author
|
Oh, d'oh, you mean in the commit. Yeah, will do. |
Contributor
Author
|
Or even more likely, you meant the nix derivation. I am apparently using a computer before being fully awake, apologies 🙈 should be good to go now. |
Contributor
|
Successfully created backport PR for |
1 task
Contributor
|
Why did no one test that the package actually builds with this change? |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Following on from #279843 (comment) and also seeing mention of this in the nix contributors matrix today.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.