Skip to content

Conversation

@amaxine
Copy link
Contributor

@amaxine amaxine commented Jan 14, 2024

Description of changes

Following on from #279843 (comment) and also seeing mention of this in the nix contributors matrix today.

Uh oh... I the next thing my hydra got stuck on is folks. I dunno why that's needed for my desktop, but the build failed on one machine and succeeded on another...

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@amaxine amaxine requested a review from bobby285271 January 14, 2024 11:12
@amaxine
Copy link
Contributor Author

amaxine commented Jan 14, 2024

I'd rather fix it but since the timeouts are extremely random I've not had the time to put together something for reproing this yet.

@bobby285271
Copy link
Member

bobby285271 commented Jan 14, 2024

LGTM, can you also put a comment linking to #279843 (comment)?

@amaxine amaxine mentioned this pull request Jan 14, 2024
13 tasks
@amaxine
Copy link
Contributor Author

amaxine commented Jan 14, 2024

Oh, d'oh, you mean in the commit. Yeah, will do.

checks were re-enabled in #279843 / 10dad20
but inconsistent timeouts still occur
@amaxine
Copy link
Contributor Author

amaxine commented Jan 14, 2024

Or even more likely, you meant the nix derivation. I am apparently using a computer before being fully awake, apologies 🙈 should be good to go now.

@nh2 nh2 merged commit 8b5ce85 into NixOS:master Jan 14, 2024
@amaxine amaxine deleted the folks-disable-checks branch January 14, 2024 12:17
@github-actions
Copy link
Contributor

Successfully created backport PR for release-23.11:

@ElvishJerricco
Copy link
Contributor

Why did no one test that the package actually builds with this change? doCheck = false removes the nativeCheckInputs, which causes the package to fail during configure with

Program python3 (dbusmock) found: NO

meson.build:117:28: ERROR: python3 not found

@ElvishJerricco ElvishJerricco mentioned this pull request Jan 14, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants