nix-cl: provide the original pname as an attribute#280384
Merged
7c6f434c merged 1 commit intoNixOS:masterfrom Jan 15, 2024
Merged
nix-cl: provide the original pname as an attribute#2803847c6f434c merged 1 commit intoNixOS:masterfrom
7c6f434c merged 1 commit intoNixOS:masterfrom
Conversation
7c6f434c
force-pushed
the
nix-cl-provide-original-pname
branch
from
71ca0fb to
6815a00
Compare
Overrides often inherit pname from the overriden package, and if they get the already-prefixed version, defaulting the systems list to [pname] produces wrong (and unintuitive) results. So we keep the prefix in the store paths for clarity, and nix-env sees disambiguated names with -i/-u (which should not be used anyway); but overrides won't be broken.
ofborg
bot
added
11.by: package-maintainer
Member
Author
|
@ofborg build sbcl.pkgs.swank |
Member
Author
|
@ofborg build sbcl.pkgs.cl-fuse |
Contributor
I think it's a good idea |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overrides often inherit pname from the overriden package, and if they get the already-prefixed version, defaulting the systems list to [pname] produces wrong (and unintuitive) results. So we keep the prefix in the store paths for clarity, and nix-env sees disambiguated names with -i/-u (which should not be used anyway); but overrides won't be broken.
Without this, #279937 seems to have broken some stuff.
@Uthar do you think this is a reasonable way to go?
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.