Skip to content

lisp-modules: Prepend Lisp name before package name for lisp pkgs#279937

Merged
7c6f434c merged 1 commit intoNixOS:masterfrom
Uthar:issue-3283
Jan 10, 2024
Merged

lisp-modules: Prepend Lisp name before package name for lisp pkgs#279937
7c6f434c merged 1 commit intoNixOS:masterfrom
Uthar:issue-3283

Conversation

@Uthar
Copy link
Contributor

@Uthar Uthar commented Jan 10, 2024

Similar to how python3.pkgs does it
#277571 (comment)

Description of changes

Prepended the Common Lisp implementation name before the package names for Lisp packages.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from 7c6f434c, hraban, lukego and nagy January 10, 2024 03:14
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Jan 10, 2024
@hraban hraban removed their request for review January 10, 2024 03:51
@7c6f434c
Copy link
Member

@ofborg build sbcl.pkgs.iolib

@7c6f434c 7c6f434c merged commit d5304c2 into NixOS:master Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants