gocode: remove

[katexochen]

Description of changes

The original removal PR (#276887) was reverted on master in (#279324), as it missed some references and the fixup would cause a mass rebuild on master (#279181).

This PR contains both the orignial removal commit and the fixups.

---

Project has been in maintenance mode sinde 2019 and was archived in 2021: https://github.com/mdempsky/gocode

For vim-go, gocode support was removed in in 2020, as documented in the changelog.

For ycmd, gocode was removed, too, see https://github.com/ycm-core/ycmd/blob/b34008abd3b51992a7b6342a4e4e79740417e63c/build.py#L547-L548

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[kirillrdy]

may i ask, what is the issue caused by removal of gocode ? I think its unlikely anyone still using gocode in 2024 ( famous last words )

[katexochen]

@kirillrdy there is no issue removing it. I just overlooked 2 references of it in the removal PR and now these fixups are causing mass rebuilds.

[katexochen]

Original PR was reverted on master, so we need to wait until the revert is part of staging, then I can rebase and cherry-pick the original commit into this PR.

[katexochen]

Original commit cherry-picked, PR description updated, ready for review. ✔️

Sorry for the mess.

[rjpcasalino]

seems like https://github.com/fatih/vim-go uses gocode and I got a build error as a result; sorry just read the description so that makes sense. I must be stuck on an older version of vim-go or nixpkgs vim-go is old? Not sure why vim-go is producing the error for me just me adding noise here - whoops

[katexochen]

@rjpcasalino what build error do you get? I think the base of this PR is broken, I've cherry-picked the changes on top of master to build them. Or test with nixpkgs-review:

Result of nixpkgs-review run on x86_64-linux 1

3 packages built:

• vimPlugins.YouCompleteMe
• vimPlugins.vim-go
• ycmd

[katexochen]

@rjpcasalino You seem to be using the unstable channel, which might be currently broken due to the pre story of this PR that is described at the beginning of the PR description. Please be patient, this has already been reverted on master, you can track it on the PR tracker.

Other than that, your issue doesn't seem to be related to this PR (which is still open and not in unstable).

[rjpcasalino]

right, sorry should have commented on the merged PR. No worries. Thanks for your work with this. Nevertheless, should gocode be removed from nixpkgs/pkgs/applications/editors/vim/plugins/overrides.nix at some point? blah, sorry for noise!

[fabianhjr]

Seems like staging had unrelated breakage.

error: evaluation aborted with the following error message: 'lib.customisation.callPackageWith: Function called without required argument "filemagic" at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-4/pkgs/development/python-modules/jira/default.nix:5

Could you rebase and if it evals will merge

[rjpcasalino]

@katexochen just wanted to thank you again for this work. My config builds wonderfully again.