Merged
Conversation
ofborg
bot
added
8.has: clean-up
donovanglover
approved these changes
Dec 26, 2023
donovanglover
added
the
12.approvals: 1
Member
|
Will wait for @kalbasit before merging for up to a week and a half (friday, january 5th). Please ping me if they haven't reviewed by then. |
donovanglover
added
the
9.needs: maintainer feedback
AndersonTorres
approved these changes
Dec 28, 2023
delroth
added
12.approvals: 2
Contributor
Author
|
@fabianhjr ping |
Member
|
seems like this needs a rebase |
katexochen
force-pushed
the
gocode/remove
branch
from
37f905d to
0e7a6ee
Compare
Contributor
Author
|
Thanks @ajs124, done. I didn't notice the conflict on mobile. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1358 |
Contributor
|
It seems like there is still usage of this in tree:
|
13 tasks
Contributor
Author
Member
|
oops. I thought I checked that. Has the revert already happened, since the currently open follow up goes to staging? |
Member
|
Usually CI would catch this, see #278777 for why it doesn't right now. I merged the revert and will revert that PR too soon to fix this for the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Project has been in maintenance mode sinde 2019 and was archived in 2021: https://github.com/mdempsky/gocode
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.