Skip to content

xdg-desktop-portal-hyprland: 1.2.6 -> 1.3.1#278784

Merged
2 commits merged intoNixOS:masterfrom
fufexan:xdph
Jan 17, 2024
Merged

xdg-desktop-portal-hyprland: 1.2.6 -> 1.3.1#278784
2 commits merged intoNixOS:masterfrom
fufexan:xdph

Conversation

@fufexan
Copy link
Contributor

@fufexan fufexan commented Jan 4, 2024

Description of changes

XDPH now builds with CMake instead of Meson + Ninja.
CHANGELOG 1.3.1
CHANGELOG 1.3.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 4, 2024
@getchoo
Copy link
Member

getchoo commented Jan 7, 2024

Result of nixpkgs-review pr 278784 run on x86_64-linux 1

3 packages built:
  • hyprlang
  • hyprlang.dev
  • xdg-desktop-portal-hyprland

@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 7, 2024
@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jan 11, 2024
@puffnfresh
Copy link
Member

xdg-desktop-portal-hyprland now has a 1.3.1 tag.

@fufexan fufexan changed the title xdg-desktop-portal-hyprland: 1.2.6 -> 1.3.0 xdg-desktop-portal-hyprland: 1.2.6 -> 1.3.1 Jan 12, 2024
@delroth delroth removed the 12.approvals: 2 This PR was reviewed and approved by two persons. label Jan 12, 2024
@nrabulinski
Copy link
Member

Result of nixpkgs-review pr 278784 run on x86_64-linux 1

3 packages built:
  • hyprlang
  • hyprlang.dev
  • xdg-desktop-portal-hyprland

@nrabulinski nrabulinski added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 15, 2024
@delroth delroth added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jan 15, 2024
@fufexan fufexan force-pushed the xdph branch 2 times, most recently from ad340a8 to e6822fb Compare January 16, 2024 07:21
@fufexan fufexan force-pushed the xdph branch 2 times, most recently from c13bab2 to ceebd3a Compare January 16, 2024 07:23
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 278784 run on x86_64-linux 1

3 packages built:
  • hyprlang
  • hyprlang.dev
  • xdg-desktop-portal-hyprland

@ghost ghost mentioned this pull request Jan 16, 2024
13 tasks
@ghost
Copy link

ghost commented Jan 16, 2024

the aarch64-linux is failing to build.
argh. aarch64 hasn't moved to gcc13, it is just x86-64. i guess the gcc13stdenv are needed. sorry about that.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aarch64-linux is still using gcc12 -- apologies.

@fufexan
Copy link
Contributor Author

fufexan commented Jan 16, 2024

Forgot, my bad.

@ghost ghost merged commit efbacad into NixOS:master Jan 17, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants