Conversation
|
Result of 3 packages built:
|
3ad1eac to
0af87f5
Compare
There was a problem hiding this comment.
i believe this needs to get rebased off master to pull in #278784
not sure why it is not registering a merge-conflict with the changes to pkgs/by-name/hy/hyprlang/package.nix and pkgs/top-level/all-packages.nix
[edit] seems this might be ok if the changes are identical to what is in master.
|
The |
ok -- however, the aarch64-linux build is failing /nix/store/wjkn3fmykn68rbpnamj9kzgw263xcga2-binutils-2.40/bin/ld: /nix/store/hddv2aciqs8k8pza6nsrhxki3ri60n1p-hyprlang-0.2.1/lib/libhyprlang.so: undefined reference to `std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_replace_cold(char*, unsigned long, char const*, unsigned long, unsigned long)@GLIBCXX_3.4.31' |
|
My bad, syncing through github does a merge instead of rebase. I'm in the middle of a pretty big rebase (9000+ commits) in nixpkgs currently, so I'll do this rebase after that's done. |
i think this link error is due to using gcc13 for libhyprlang but hyprpaper is gcc12 on aarch64-linux, so you'll have to add the gcc13stdev to hyprpaper in all-packages.nix too. [edit] looks like #272674 is in staging-next, so whenever that merges in to master (1 month?) gcc13 will be the default for aarch64-linux as well. |
|
@ofborg build hyprpaper |
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.