Skip to content

Unify XP Pen tablet drivers#277176

Closed
sochotnicky wants to merge 1 commit intoNixOS:masterfrom
sochotnicky:sochotnicky/add-xp-pen-generic
Closed

Unify XP Pen tablet drivers#277176
sochotnicky wants to merge 1 commit intoNixOS:masterfrom
sochotnicky:sochotnicky/add-xp-pen-generic

Conversation

@sochotnicky
Copy link
Contributor

@sochotnicky sochotnicky commented Dec 27, 2023

Description of changes

This implements changes proposed in #213263 to unify drivers for XP Pen devices in one application.

XP Pen app has hardcoded /usr/lib/pentablet path in the binary that can't be overriden and so we need to create FHS structure for it.

Known issues:

  • Runs but probably does not work on Wayland
  • Breaks on multi-user systems because it doesn't cleanup after exit (it leaves lock file around so different users can't run the app).

TODO:

  • Add hardware module with udev rules that will provide access to the devices for ordinary users. Basically: SUBSYSTEM=="usb", ACTION=="add", ATTRS{idVendor}=="28bd", MODE="0660", TAG+="uaccess"

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This implements changes proposed in
NixOS#213263
@sochotnicky sochotnicky force-pushed the sochotnicky/add-xp-pen-generic branch from d1495ca to 6ae74f5 Compare December 27, 2023 21:43
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Dec 27, 2023
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Dec 27, 2023
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/how-do-i-change-package-download-link-or-fix-broken-packagen-via-local-file/41141/4

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 20, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
@gepbird
Copy link
Contributor

gepbird commented Oct 30, 2025

Hi @sochotnicky, are you still interested in working on this?

In #351647 I added a generic/unified derivation for all XP-Pen drivers and made major versions available as xppen_3 and xppen_4. It also has a NixOS module that adds the xppen package as a udev package, which should take care of your TODO.

However the removal of g430 and deco-01-v2 drivers is only done in this PR, after a rebase you could add an alias that points to the unified packages.

@nixpkgs-ci nixpkgs-ci bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 30, 2025
@sochotnicky
Copy link
Contributor Author

Hi @sochotnicky, are you still interested in working on this?

In #351647 I added a generic/unified derivation for all XP-Pen drivers and made major versions available as xppen_3 and xppen_4. It also has a NixOS module that adds the xppen package as a udev package, which should take care of your TODO.

However the removal of g430 and deco-01-v2 drivers is only done in this PR, after a rebase you could add an alias that points to the unified packages.

I no longer have access to the device so I can't really finish this off and test it.

@sochotnicky
Copy link
Contributor Author

Since it's been a good long while and I don't have this device anymore - I'll close but if anyone wants to pick it up feel free to reuse if it makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants