python3Packages.wagtail: relax django-taggit dependency#275356
python3Packages.wagtail: relax django-taggit dependency#275356natsukium merged 2 commits intoNixOS:masterfrom
Conversation
bb66b34 to
646e423
Compare
|
Thanks for the review! Is there anything missing to get this PR merged? |
|
|
|
@NickCao see the notes in the PR description:
This PR fixes building the |
|
@ofborg build python311Packages.wagtail python311Packages.wagtail-localize |
|
As you can see, the build of |
646e423 to
3df6e43
Compare
3df6e43 to
6425843
Compare
|
The build works on this PR branch but is indeed broken on master because of #271586 . The Note the dependency was fixed upstream on the main branch so this patch can be removed when the next Wagtail version will be released. |
|
Please use
|
Description of changes
django-taggit was upgraded in 94aac10, but this version is not supported by Wagtail 5.2.2. I checked the django-taggit changelog, and the changes in 5.0 don’t have any impact on Wagtail (I’ve opened a PR to change this upstream) so it should be safe to relax the dependency.
I have no idea why the
python3Packages.wagtailpackage can be built, and why building thepython3Packages.wagtail-localizepackage (which depends on wagtail) fails.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.