python3Packages.wagtail: 5.1.3 -> 5.2.2#273359
Merged
wegank merged 2 commits intoNixOS:masterfrom Dec 19, 2023
Merged
Conversation
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
10.rebuild-darwin: 1-10
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3100 |
SuperSandro2000
approved these changes
Dec 14, 2023
delroth
added
the
12.approvals: 1
Member
|
Result of 2 packages failed to build:8 packages built successfully:
|
Member
|
same issue is on hydra: https://hydra.nixos.org/build/243672281 Result of 4 packages failed to build:
16 packages built:
LGTM |
Member
|
The x86_64-darwin error might be a regression however, since it passes on hydra. @wegank, is opencv float precision issues common on darwin? |
Member
|
Result of 4 packages failed to build:
16 packages built:
|
wegank
approved these changes
Dec 18, 2023
SuperSandro2000
approved these changes
Dec 18, 2023
delroth
added
12.approvals: 2
Contributor
Author
|
The problem actually comes from building This PR should fix the problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Upgrade Wagtail to 5.2.2 based on the original nixpkgs-update PR. Note that Wagtail 5.2 bumped the requirement of
django-modelclusterto 6.1 so this package has to be upgraded as well.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.