Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/mattermost: fix mkPackageOption default name #272143

Merged
merged 1 commit into from
Dec 4, 2023
Merged

nixos/mattermost: fix mkPackageOption default name #272143

merged 1 commit into from
Dec 4, 2023

Conversation

h7x4
Copy link
Member

@h7x4 h7x4 commented Dec 4, 2023

Description of changes

Fixes typo in #261702

Ran nix build .#nixosTests.mattermost

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Dec 4, 2023
@h7x4 h7x4 mentioned this pull request Dec 4, 2023
Merged
20 tasks
@h7x4 h7x4 requested a review from mohe2015 December 4, 2023 22:26
@wegank wegank merged commit 70e0fbe into NixOS:master Dec 4, 2023
@h7x4 h7x4 deleted the nixos-mattermost-fix-package-option-name branch December 8, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohe2015 mohe2015 Awaiting requested review from mohe2015

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h7x4 @wegank