treewide: use mkPackageOption

[h7x4]

Description of changes

This commit replaces a lot of usages of mkOption with the package type, to be mkPackageOptionMD, in order to reduce the amount of code.

I haven't changed all of these, but this is a good amount of them. Maybe we could just start with this, and do another PR later? I might add on stuff as time goes if it doesn't seem to get merged anytime soon.

Also, I haven't used any tool for this, I've just manually gone through them all. There might be some human errors due to that.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.
  Module Updates
  • changes are backward compatible
  • removed options are declared with mkRemovedOptionModule
  • changes that are not backward compatible are documented in release notes
  • module tests succeed on ARCHITECTURE This is probably too large for me to build, not entirely sure how I would go about doing this.
  • options types are appropriate
  • options description is set
  • options example is provided I've transferred the examples where the option already had one
  • documentation affected by the changes is updated

[wegank]

Why not just use mkPackageOption?

nixpkgs/lib/options.nix

Line 226 in 96ae9c9

mkPackageOptionMD = mkPackageOption;

[h7x4]

@wegank Mostly for ease of backporting, at least for however many days we have left. A treewide PR from mkPackageOptionMD to mkPackageOption will probably be done at some point in 23.11, as mkPackageOptionMD stuff existed before this PR.

Edit: On second thought, I realize this doesn't make sense. Changes usually don't get backported as entire files, only the commits themselves. And since there are no reason to backport this change, I could've just as well just used mkPackageOption

[h7x4]

This is ready for reviews. I don't think I'll be changing it much more apart from review comments.

If it doesn't get merged within 23.11 feature freeze, I'll swap all the mkPackageOptionMDs to their mkPackageOption variant, but for now I think I'll just keep it as is, since we'll need another treewide PR to convert the others back anyway.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2815

[h7x4]

Updated the PR from mkPackageOptionMD -> mkPackageOption, and fixed the merge conflicts