libdeltachat: do not use __FILE__ as a path to headers location#268920
Merged
dotlambda merged 1 commit intoNixOS:masterfrom Nov 21, 2023
Merged
libdeltachat: do not use __FILE__ as a path to headers location#268920dotlambda merged 1 commit intoNixOS:masterfrom
dotlambda merged 1 commit intoNixOS:masterfrom
Conversation
dotlambda
reviewed
Nov 21, 2023
This was referenced Nov 21, 2023
dotlambda
reviewed
Nov 21, 2023
Contributor
Author
Yeah, |
dotlambda
reviewed
Nov 21, 2023
`-fmacro-prefix-map=` option can redirect path from the actual source location to the unrelated path (`build-time` vs `debug-time`). The change expands `__FILE__` in `deltachat.h` to the absolute location to stop relying on `__FILE__` expansion. The change fixes `python3.pkgs.deltachat` for me. Co-authored-by: Robert Schütz <github@dotlambda.de> Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
trofi
force-pushed
the
libdeltachat-fix-path
branch
from
9fe194e to
30bdf7a
Compare
Contributor
Author
|
Squashed all the applied suggestions into a single commit. |
ofborg
bot
added
10.rebuild-darwin: 1-10
Member
|
Result of 1 package failed to build:
8 packages built:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-fmacro-prefix-map=option can redirect path from the actual source location to the unrelated path (build-timevsdebug-time).The change expands
__FILE__indeltachat.hto the absolute location to stop relying on__FILE__expansion.The change fixes
python3.pkgs.deltachatfor me.Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Priorities
Add a 👍 reaction to pull requests you find important.