Skip to content

deltachat-desktop: 1.41.1 -> 1.41.2#267870

Closed
totoroot wants to merge 2 commits intoNixOS:masterfrom
totoroot:update/deltachat-desktop-1.41.2
Closed

deltachat-desktop: 1.41.1 -> 1.41.2#267870
totoroot wants to merge 2 commits intoNixOS:masterfrom
totoroot:update/deltachat-desktop-1.41.2

Conversation

@totoroot
Copy link
Contributor

Description of changes

  • Update package deltachat-desktop from version 1.41.1 to 1.41.2.

Ping @dotlambda

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@totoroot totoroot requested a review from dotlambda November 16, 2023 10:58
@totoroot totoroot added the 8.has: package (update) This PR updates a package to a newer version label Nov 16, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 16, 2023
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update libdeltachat to the appropriate version.

@totoroot
Copy link
Contributor Author

Update libdeltachat to the appropriate version.

Done!

@totoroot totoroot requested a review from dotlambda November 17, 2023 09:57
@ofborg ofborg bot removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 17, 2023
@dotlambda
Copy link
Member

Result of nixpkgs-review pr 267870 run on x86_64-linux 1

7 packages failed to build:
  • deltachat-cursed
  • deltachat-cursed.dist
  • kdeltachat
  • python310Packages.deltachat
  • python310Packages.deltachat.dist
  • python311Packages.deltachat
  • python311Packages.deltachat.dist
3 packages built:
  • deltachat-desktop
  • deltachat-repl
  • libdeltachat

Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python3.pkgs.deltachat fails to build and a new version of deltachat-desktop is available.

@dotlambda
Copy link
Member

I investigated the build failure of the Python bindings:

FileNotFoundError: [Errno 2] No such file or directory: b'/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-libdeltachat-1.121.0/include/deltachat.h'

This path is returned by https://github.com/deltachat/deltachat-core-rust/blob/40dea771cc4d97d48949a6ececd7ef2be238b3cf/deltachat-ffi/deltachat.h#L7291.
Since the same happens on master I'll try to bisect the failure.

@trofi
Copy link
Contributor

trofi commented Nov 21, 2023

Proposed __FILE__ expansion fix as #268920.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments