qt5.wrapQtAppsHook: go back to buildPackages.makeBinaryWrapper#266375
Conversation
Fixes pkgsCross.aarch64-multiplatform.zbar
github-actions
bot
added
the
6.topic: qt/kde
ghost
mentioned this pull request
ghost
marked this pull request as ready for review
ofborg
bot
added
10.rebuild-darwin: 0
Member
|
Better fix #266537 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This undoes one small change from
which caused
wrapQtAppsHookto stop working on all packages that use it and do not setwrapQtApps=false.For example,
pkgsCross.aarch64-multiplatform.zbar.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)