Conversation
and simplify some things remove now unnecessary use of buildPackages
The `self` does not contain spliced packages, callPackage works properly.
github-actions
bot
added
the
6.topic: qt/kde
12 tasks
ofborg
bot
added
10.rebuild-darwin: 0
ghost
self-assigned this
|
Working on testing this. Here is the qt6 version: #264959 |
|
I'll try to rebase #264965 on this |
Member
Author
|
This reduces the amount of derivations to build after building all the succeeding ones
14 vs 8 |
Member
Author
|
|
|
I have the fix. There was a rebase issue with the path to meson's |
This was referenced Nov 3, 2023
ghost
reviewed
Nov 9, 2023
| propagatedBuildInputs = [ self.qtbase.dev buildPackages.makeBinaryWrapper ] | ||
| ++ lib.optional stdenv.isLinux self.qtwayland.dev; | ||
| } ../hooks/wrap-qt-apps-hook.sh; | ||
| propagatedBuildInputs = [ qtbase.dev makeBinaryWrapper ] |
There was a problem hiding this comment.
Something still isn't right here.
Artturin
added
the
6.topic: cross-compilation
This was referenced Nov 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)