Skip to content

Comments

python311Packages.flufl-lock: 7.1.1 -> 8.0.2; python311Packages.flufl-i18n: 4.1.1 -> 5.0.2; rename#265198

Closed
natsukium wants to merge 9 commits intoNixOS:masterfrom
natsukium:flufl
Closed

python311Packages.flufl-lock: 7.1.1 -> 8.0.2; python311Packages.flufl-i18n: 4.1.1 -> 5.0.2; rename#265198
natsukium wants to merge 9 commits intoNixOS:masterfrom
natsukium:flufl

Conversation

@natsukium
Copy link
Member

Description of changes

part of #245383

Changelog: https://gitlab.com/warsaw/flufl.lock/-/blob/8.0.2/docs/NEWS.rst
Changelog: https://gitlab.com/warsaw/flufl.i18n/-/raw/5.0.2/docs/NEWS.rst

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Nov 3, 2023
@natsukium
Copy link
Member Author

natsukium commented Nov 3, 2023

Result of nixpkgs-review pr 265198 at a490d3a run on aarch64-darwin 1

1 package marked as broken and skipped:
  • dvc-with-remotes
10 packages built successfully:
  • dvc (python311Packages.dvc)
  • python310Packages.dvc
  • python310Packages.dvclive
  • python310Packages.flufl-bounce
  • python310Packages.flufl-i18n
  • python310Packages.flufl-lock
  • python311Packages.dvclive
  • python311Packages.flufl-bounce
  • python311Packages.flufl-i18n
  • python311Packages.flufl-lock

Result of nixpkgs-review pr 265198 at a490d3a run on x86_64-linux 1

2 packages failed to build:
12 packages built successfully:
  • dvc (python311Packages.dvc)
  • dvc-with-remotes
  • mailman-web
  • python310Packages.dvc
  • python310Packages.dvclive
  • python310Packages.flufl-bounce
  • python310Packages.flufl-i18n
  • python310Packages.flufl-lock
  • python311Packages.dvclive
  • python311Packages.flufl-bounce
  • python311Packages.flufl-i18n
  • python311Packages.flufl-lock

Result of nixpkgs-review pr 265198 at 6464cb7 run on x86_64-linux 1

14 packages built successfully:
  • dvc (python311Packages.dvc)
  • dvc-with-remotes
  • mailman
  • mailman-hyperkitty
  • mailman-web
  • python310Packages.dvc
  • python310Packages.dvclive
  • python310Packages.flufl-bounce
  • python310Packages.flufl-i18n
  • python310Packages.flufl-lock
  • python311Packages.dvclive
  • python311Packages.flufl-bounce
  • python311Packages.flufl-i18n
  • python311Packages.flufl-lock

@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package labels Nov 3, 2023
@ofborg ofborg bot requested review from CMCDragonkai, alyssais and fabaff November 3, 2023 10:57
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Nov 3, 2023
# error: Command '['/nix/store/s6fgyqbk8vn1014daznm5kqx90xdn86x-python3-3.10.13/bin/python3.10', '-m', 'pip', '--disable-pip-version-check', 'wheel', '--no-deps', '-w', '/build/tmp9yk3_jzi', '--quiet', 'flufl.lock>=5.1']' returned non-zero exit status 1.
# There are so many network related errors and it is difficult to run pytestCheckHook.
# (1822 failed, 164 passed, 2 xfailed, 26 warnings, 11 errors)
doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this just mean we're missing checkInputs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, perhaps not. Because flufl-lock is already included in propagatedBuildInputs.
This sphinxcontrib_newsfeed case reported "missing docutils", but docutils was unrelated.
#263504 #264924

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others have a similar issue with flufl switching to pdm: treeverse/dvc#9654

if we drop the updates e41e58e, a490d3a and enable the mailman checks 6464cb7 (drop commit) everything keeps working...

@Stunkymonkey
Copy link
Contributor

@natsukium you have to remove some commits, because #285868 was merged. Or do you want to close it?

Thanks for your work.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 20, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
@natsukium
Copy link
Member Author

This PR is too old.

@natsukium natsukium closed this Sep 13, 2024
@natsukium natsukium deleted the flufl branch September 13, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants