Skip to content

python311Packages.sphinxcontrib_newsfeed: fix build#264924

Closed
dotlambda wants to merge 2 commits intoNixOS:masterfrom
dotlambda:sphinxcontrib-newsfeed-fix
Closed

python311Packages.sphinxcontrib_newsfeed: fix build#264924
dotlambda wants to merge 2 commits intoNixOS:masterfrom
dotlambda:sphinxcontrib-newsfeed-fix

Conversation

@dotlambda
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Nov 2, 2023
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package labels Nov 2, 2023
@ofborg ofborg bot requested a review from gebner November 2, 2023 02:52
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 2, 2023
@marsam
Copy link
Contributor

marsam commented Nov 2, 2023

I think these changes are already included in staging-next: df59f94 and 91bf7ef

@dotlambda
Copy link
Member Author

I think these changes are already included in staging-next: df59f94 and 91bf7ef

Interesting, the build doesn't fail despite missing docutils.

@dotlambda dotlambda closed this Nov 2, 2023
@dotlambda dotlambda deleted the sphinxcontrib-newsfeed-fix branch November 2, 2023 15:57
@mweinelt
Copy link
Member

mweinelt commented Nov 2, 2023

Might be related to #250865

@dotlambda
Copy link
Member Author

Might be related to #250865

No, docutils is not listed in install_requires.

@natsukium
Copy link
Member

I have seen similar examples.
When setup.py check runs, it complains that it can't find a package it shouldn't need. I added pytestCheckHook to that package, and the error disappeared.
I don't look into the cause, but I think the legacy setup.py is causing some bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants