Skip to content

tzdata: copy leap-seconds.list to $out/share/zoneinfo#265124

Merged
delroth merged 1 commit intoNixOS:stagingfrom
onemoresuza:hare-tzdata
Nov 26, 2023
Merged

tzdata: copy leap-seconds.list to $out/share/zoneinfo#265124
delroth merged 1 commit intoNixOS:stagingfrom
onemoresuza:hare-tzdata

Conversation

@onemoresuza
Copy link
Contributor

@onemoresuza onemoresuza commented Nov 3, 2023

Description of changes

tzdata: copy leap-seconds.list to $out/share/zoneinfo

Some packages rely on that file for timekeeping, e. g., hare.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Some packages rely on that file for timekeeping, e. g., hare[1].

[1]: https://harelang.org/distributions/
@onemoresuza
Copy link
Contributor Author

I've read the Contributing.md section you mentioned, @eclairevoyant. Thanks for closing that PR before a mass ping!

@ofborg ofborg bot added the 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. label Nov 3, 2023
@ofborg ofborg bot requested review from ajs124 and fpletz November 3, 2023 03:27
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Nov 3, 2023
@onemoresuza onemoresuza changed the title tzdata: copy leap-seconds.list to $out/share/zoneinfo; hare: patch hardcoded tzdata paths; harec: adopt package tzdata: copy leap-seconds.list to $out/share/zoneinfo Nov 7, 2023
@onemoresuza
Copy link
Contributor Author

Reworked this PR, so that only the leap-seconds.list file copy is added. The Hare related changes can be done on separate PRs.

@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Nov 12, 2023
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants