treecat: init at 1.0.2-unstable-2023-11-28#271013
Merged
pbsds merged 1 commit intoNixOS:masterfrom Dec 15, 2023
Merged
Conversation
ofborg
bot
added
8.has: package (new)
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3014 |
pbsds
reviewed
Dec 6, 2023
Member
pbsds
left a comment
pbsds
left a comment
There was a problem hiding this comment.
Result of nixpkgs-review pr 271013 run on x86_64-linux 1
2 packages built:
- treecat
- treecat.man
- package path fits guidelines
- package name fits guidelines
- package version fits guidelines
- package builds on x86_64-linux
- executables tested on x86_64-linux
-
meta.descriptionis set and fits guidelines -
meta.licensefits upstream license -
meta.platformsis set -
meta.maintainersis set - build time only dependencies are declared in
nativeBuildInputs - source is fetched using the appropriate function
- the list of
phasesis not overridden - when a phase (like
installPhase) is overridden it starts withrunHook preInstalland ends withrunHook postInstall. - patches have a comment describing either the upstream URL or a reason why the patch wasn't upstreamed
- patches that are remotely available are fetched rather than vendored
LGTM, but pinning harec unnecesarily i think is hasty
Contributor
Author
|
Rebased against master after the merge of #271476. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Initializes
treecat:Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Priorities
Add a 👍 reaction to pull requests you find important.