Skip to content

anki: 2.1.66 -> 23.10.1#264796

Merged
wegank merged 1 commit intoNixOS:masterfrom
paveloom:anki
Nov 30, 2023
Merged

anki: 2.1.66 -> 23.10.1#264796
wegank merged 1 commit intoNixOS:masterfrom
paveloom:anki

Conversation

@paveloom
Copy link
Copy Markdown
Member

@paveloom paveloom commented Nov 1, 2023

Description of changes

https://github.com/ankitects/anki/releases/tag/23.10
https://github.com/ankitects/anki/releases/tag/23.10.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg Bot requested review from euank and oxij November 1, 2023 12:26
@ofborg ofborg Bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 1, 2023
@a-kenji
Copy link
Copy Markdown
Member

a-kenji commented Nov 1, 2023

Result of nixpkgs-review pr 264796 run on x86_64-linux 1

6 packages built:
  • anki
  • anki.dist
  • anki.doc
  • anki.man
  • mnemosyne
  • mnemosyne.dist

Also tested basic functionality, seems to work well.

@paveloom paveloom changed the title anki: 2.1.66 -> 23.10 anki: 2.1.66 -> 23.10.1 Nov 23, 2023
Copy link
Copy Markdown
Member

@euank euank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I verified anki runs and works for me with this.

Thank you!

@a-kenji
Copy link
Copy Markdown
Member

a-kenji commented Nov 23, 2023

Result of nixpkgs-review pr 264796 run on x86_64-linux 1

6 packages built:
  • anki
  • anki.dist
  • anki.doc
  • anki.man
  • mnemosyne
  • mnemosyne.dist

Copy link
Copy Markdown
Member

@martinetd martinetd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code-wise LGTM, the updated patch content is identical to what I had for 23.10beta6 a while back.

Comment thread pkgs/games/anki/patches/skip-formatting-python-code.patch Outdated
Comment thread pkgs/games/anki/patches/skip-formatting-python-code.patch Outdated
@wegank wegank merged commit 27ed44c into NixOS:master Nov 30, 2023
@paveloom paveloom deleted the anki branch November 30, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants